[Next] Fix OSD level animation lag when using gesture volume control #13338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix jerky level animation for small value changes, if level value changes by less than 0.4 do it using new fast constant, set it to zero for now. the 0.4 is kind of hardcoded as the I wanted the brightness (that jumps by 0.4 on my system) to have the 100ms level animation and all below it 0ms.
throttling OSD manager show function calls to prevent event flooding when using gestures for volume control, which too was contributing to some choppiness.
Updates Clutter animation to linear to make is smooth and lower burstiness of animation.
clefebvre
changed the title
Contributor
Author
|
hey @mtwebster , sorry for the bother, but c8cb4ec is failing on mint22 build but the later commit is passing, also since I'm new can you check if the code is following good standards. |
Member
|
Hi sorry I missed your comment, don't worry about those builds - they're meaningless for commits like this that don't touch compiled code, and there are many reasons unrelated to a pull request that can cause failures as well. |
Contributor
Author
|
I made a typo in my code and crashed my ui, thought something was wrong with the code so closed the pull request and checked the code, no issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes visual laggy appearance of level animation in OSD when using touchpad gesture volume control, from #12760.
Need
The previous behavior forces 100ms LEVEL_ANIMATION_TIME transition for all level changes, even minuscule ones, causes extreme lag when using gestures. (addressable by throttling alone for now)
Fix
Throttled osdWindowManager.show() call in similar fashion as in zoom control class, prevent event flooding.
Initially made other changes, but realised they were not really necessary and felt bloaty, throttling works fine.
Thanks for reviewing.
Closes #12760